CLUCK Version 2 #24
Merged
CLUCK Version 2 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Micah Powch <[email protected]>
Co-authored-by: Micah Powch <[email protected]>
Co-authored-by: Micah Powch <[email protected]>
azaleacolburn
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
I had some minor nitpicks/revisions to a few utility files, including the way errors are handled generally, but then I realized it didn't really matter, since all the the higher-level architectural decisions / implementations are great.
If you want to see my nitpicks, let me know and I'll submit them, the contents of you'll of course be free to accept or reject. But I don't think any of my nitpicks should prevent this from getting merged, so I'll omit them by default.
Co-authored-by: Azalea Colburn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All new features including:
This has a completely separate starting point from the original CLUCK, but with preserved history, so you may want to ignore the deleted side in the diff. Any feedback would be appreciated, there are setup instructions